Take indata2json at the commit that keeps a trailing zero spline value - #803
Open
CharlesCNorton wants to merge 2 commits into
Open
Take indata2json at the commit that keeps a trailing zero spline value#803CharlesCNorton wants to merge 2 commits into
CharlesCNorton wants to merge 2 commits into
Conversation
CharlesCNorton
force-pushed
the
fix/indata2json-pin
branch
from
September 7, 2026 10:50
306bff8 to
b3c76a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indata2jsonat the pinnedf59e3ddtrimmed the trailing zeros ofam_aux_f,ai_aux_fandac_aux_findependently of their knot arrays, so an INDATA file whose spline profile ends at exactly zero, the ordinary case for a pressure or current profile, converted to a JSON with one value fewer than knots andVmecINDATA::FromJsonrejected it. The shippedinput.cth_like_fixed_bdy_spline_pressurecould not be loaded throughVmecInput.from_file.Upstream fixed this in jonathanschilling/indata2json#12 (
df7e911), which sizes both arrays of a pair from the knot array. This takes that commit. The new test loads the shipped spline INDATA and requires all 201 knots and values, equal to the shipped JSON; it fails at the previous pin.tests/test_init.pypasses.