Fix missing quasisymmetry re-export causing "Test conda env" job failure - #826
Draft
jurasic-pf with Copilot wants to merge 2 commits into
Draft
Fix missing quasisymmetry re-export causing "Test conda env" job failure#826jurasic-pf with Copilot wants to merge 2 commits into
jurasic-pf with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: jurasic-pf <166746189+jurasic-pf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Test conda env
Fix missing quasisymmetry re-export causing "Test conda env" job failure
Sep 8, 2026
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 740cf56 | Previous: de5166b | Ratio |
|---|---|---|---|
benchmarks/test_benchmarks.py::test_bench_simsopt_finite_difference_gradient |
0.4870138609999799 seconds (stddev: 0) |
0.3059909609996794 seconds (stddev: 0) |
1.59 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Test conda env" job (run 34170619332) failed with
AttributeError: module 'vmecpp.simsopt_compat' has no attribute 'magnetic_field_strength'(and two similar errors), becausetests/test_qs.pycalls these functions onvmecpp.simsopt_compatbut they were never actually exposed there.Root cause
src/vmecpp/_qs.pydefinesmagnetic_field_strength,quasisymmetry_residuals, andquasisymmetry_total.vmecpp.simsopt_compat", but the rename commit that introduced this comment never added the corresponding import — the re-export was a no-op comment.Fix
src/vmecpp/simsopt_compat.pyto re-exportmagnetic_field_strength,quasisymmetry_residuals, andquasisymmetry_totalfromvmecpp._qs.src/vmecpp/_qs.pyandtests/test_qs.py, which were part of the same in-flight change but not yet present on this branch, so the re-export has something to target and the fix is exercised by the existing test.