refactor: apply quality baseline on master

Author: c15k0

composer.json

@@ -11,14 +11,12 @@
   ],
   "homepage": "https://github.com/psfs/core",
   "require": {
-    "php": ">=8",
+    "php": ">=8.2",
     "ext-json": "*",
     "ext-curl": "*",
-    "ext-gmp": "*",
     "psfs/propel": "dev-master",
     "symfony/console": "7.4.18",
     "symfony/finder": "7.4.17",
-    "symfony/translation": "7.4.17",
     "twig/twig": "3.28.0",
     "monolog/monolog": "3.11.0",
     "matthiasmullie/minify": "1.3.75",
@@ -27,8 +25,7 @@
   },
   "require-dev": {
     "phpunit/phpunit": "11.5.56",
-    "roave/security-advisories": "dev-master",
-    "symfony/process": "7.4.18"
+    "roave/security-advisories": "dev-master"
   },
   "config": {
     "optimize-autoloader": true,

src/base/dto/ValidatableDtoTrait.php

@@ -4,6 +4,8 @@
 
 trait ValidatableDtoTrait
 {
+    abstract protected function checkCastedValue(mixed $rawValue, string $type);
+
     private static ?\WeakMap $__validationInputMap = null;
     private ?ValidationResult $__validationResult = null;
 
@@ -60,4 +62,3 @@ private function getValidationInputData(): array
         return is_array($data) ? $data : [];
     }
 }
-

src/base/extension/traits/CssTrait.php

@@ -110,7 +110,7 @@ protected function loopCssLines($file)
     }
 
     /**
-     * @param array $source
+     * @param array{0:string,1:string} $source
      * @param string $file
      */
     protected function extractCssResources($source, $file)

src/base/types/AuthApi.php

@@ -38,7 +38,7 @@ public function init()
      */
     private function checkAuth()
     {
-        $namespace = explode('\\', $this->getModelTableMap());
+        $namespace = explode('\\', (string)$this->getModelTableMap());
         $module = strtolower($namespace[0]);
         $secret = Config::getInstance()->get($module . '.api.secret');
         if (null === $secret) {

src/base/types/helpers/AssetsHelper.php

@@ -14,10 +14,10 @@ class AssetsHelper
 {
 
     /**
-     * @param string $source
+     * @param array{1:string} $source
      * @return string
      */
-    public static function extractSourceFilename($source): string
+    public static function extractSourceFilename(array $source): string
     {
         $sourceFile = preg_replace("/'/", "", $source[1]);
         if (preg_match('/\#/', $sourceFile)) {

src/base/types/helpers/FileHelper.php

@@ -77,10 +77,9 @@ public static function deleteFile(string $path): bool
     }
 
     /**
-     * @template T
      * @param string $lockPath
-     * @param callable():T $callback
-     * @return T|null
+     * @param callable $callback
+     * @return mixed
      */
     public static function withExclusiveLock(string $lockPath, callable $callback): mixed
     {

src/base/types/helpers/FilesystemTreeHelper.php

@@ -3,6 +3,7 @@
 namespace PSFS\base\types\helpers;
 
 use PSFS\base\exception\ConfigException;
+use PSFS\base\Logger;
 
 class FilesystemTreeHelper
 {
@@ -12,7 +13,9 @@ public static function deleteDir(string $dir): void
             return;
         }
         if (is_link($dir)) {
-            @unlink($dir);
+            if (!@unlink($dir)) {
+                Logger::log('[FilesystemTreeHelper] Unable to remove symlink: ' . $dir, LOG_WARNING);
+            }
             return;
         }
         $objects = scandir($dir) ?: [];

src/base/types/helpers/InjectorDefinitionHelper.php

@@ -77,7 +77,7 @@ public static function buildVariableDefinition(string $instanceType, bool $requi
     }
 
     /**
-     * @return array{string,bool}
+     * @return array{0:string,1:bool}
      */
     private static function normalizeInstanceType(string $instanceType): array
     {

src/base/types/helpers/InjectorHelper.php

@@ -173,7 +173,7 @@ public static function getLabel($doc, ReflectionProperty $property = null)
 
     /**
      * @param $doc
-     * @return null|array
+     * @return array|string|null
      */
     public static function getValues($doc, ReflectionProperty $property = null)
     {

src/base/types/helpers/MetadataReader.php

@@ -97,9 +97,11 @@ public static function resetEngineCaches(): void
 
     private static function engine(): MetadataEngineInterface
     {
-        if (!(self::$engine instanceof MetadataEngineInterface)) {
-            self::$engine = new MetadataEngine();
+        $engine = self::$engine;
+        if (!$engine instanceof MetadataEngineInterface) {
+            $engine = new MetadataEngine();
+            self::$engine = $engine;
         }
-        return self::$engine;
+        return $engine;
     }
 }