From 63e4e07dba00e46faee561b1c9f22beb13cdce46 Mon Sep 17 00:00:00 2001 From: Maqsood Ahmad Date: Mon, 12 Oct 2026 09:16:49 +0530 Subject: [PATCH] Set SIMPLECOV=yes on the Codecov lane in module_ci The Codecov upload added in 70e9e0b expects coverage/.resultset.json, but nothing in module_ci enabled SimpleCov, so the file is never written and the upload fails the Ruby 3.2 spec lane (fail_ci_if_error: true) on every repo that has CODECOV_TOKEN set, e.g. puppetlabs/provision. puppetlabs_spec_helper only starts SimpleCov when SIMPLECOV == 'yes'. Set it on the "Run tests" step under the same condition as the upload, so repos without the token (and without simplecov in their Gemfile) are unaffected. Co-Authored-By: Claude --- .github/workflows/module_ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/module_ci.yml b/.github/workflows/module_ci.yml index aca1d72..0c45118 100644 --- a/.github/workflows/module_ci.yml +++ b/.github/workflows/module_ci.yml @@ -184,6 +184,9 @@ jobs: bundle exec dependency-checker metadata.json - name: "Run tests" + env: + # Generate coverage/.resultset.json for the Codecov upload below (same condition). + SIMPLECOV: ${{ (inputs.runs_on == 'ubuntu-latest' && matrix.ruby_version == '3.2' && env.CODECOV_TOKEN != '') && 'yes' || 'no' }} run: | bundle exec rake parallel_spec