Repository navigation
(PA-7783) Recognize Raspbian as a Debian platform in install task - #855
Merged
Merged
Conversation
The puppet_agent::install task's platform case statement only matched "Debian", so Raspberry Pi OS (which facts reports as "Raspbian" even though it's Debian 12/bookworm-based) fell through to the unsupported- platform error instead of resolving a .deb download URL. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Updates the install task to recognize Raspbian as a Debian platform.
Changes:
- Adds
Raspbianto the existing Debian branch. - Reuses Debian package and codename resolution logic.
File summaries
| File | Description |
|---|---|
tasks/install_shell.sh |
Recognizes Raspbian as a Debian platform. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
joshcooper
approved these changes
Sep 18, 2026
joshcooper
deleted the
PA-7783/main/support-raspbian-in-install-task
branch
September 18, 2026 20:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundle exec rake task_acceptancefailures againstdebian-12-armhf(Raspberry Pi OS / Raspbian) hardware, as part of PA-7783 — step 3 of the "How to add a platform for puppet-agent" runbook (adding Debian 12 ARMv7L support).puppet_agent::installtask's platformcasestatement intasks/install_shell.shonly matched"Debian", so on Raspberry Pi OS — which thefactsmodule reports as platformRaspbian, even though it's Debian 12/bookworm-based — it fell through with no matching branch,deb_codename/download_urlwere never set, and the task exited withSorry Raspbian is not supported yet!."Raspbian"as an alias on the existing"Debian"branch, so it resolves the samedeb_codename/download URL logic (major_version"12" →bookworm). This follows the same alias pattern already used for other Debian-derivative distros in this file (e.g."Linuxmint"|"LinuxMint").Root cause (from the failing run, before the fix)
Both
task_spec/spec/acceptance/init_spec.rbtests (installs puppetcore8-nightly,upgrades to puppetcore9-nightly) failed identically against adebian-12-armhf(Raspbian) target since the underlying task call fails before it ever gets to the assertions — the spec file itself needed no changes, since it's platform-agnostic (target_platformdriven by the inventory).Verification (after the fix)
Re-ran
bundle exec rake task_acceptanceagainst a freshdebian-12-armhf(Raspbian) target (pi-deb-04.it.msp.perforce.net) — both tests now pass:Test plan
bash -n tasks/install_shell.sh— syntax OKshellcheck tasks/install_shell.sh— no new warnings introduced by this change (pre-existing warnings elsewhere in the file are unrelated)bundle exec rake task_acceptanceagainst a realdebian-12-armhf(Raspbian) Raspberry Pi target — 2 examples, 0 failures (bothpuppetcore8-nightlyinstall andpuppetcore9-nightlyupgrade succeed)🤖 Generated with Claude Code