Skip to content

Commit f70eb72

Browse files
authored
Multi-line 'if:' conditions without '${{ }}' (#324)
2 parents d283f62 + 9a281de commit f70eb72

2 files changed

Lines changed: 8 additions & 16 deletions

File tree

‎.github/workflows/CompletePipeline.yml‎

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -455,9 +455,8 @@ jobs:
455455
- PublishTestResults
456456
# not 'success() || failure()', because that's false if a dependency was skipped
457457
if: >-
458-
${{ !cancelled()
458+
!cancelled()
459459
&& inputs.cleanup == 'true'
460-
}}
461460
with:
462461
json: ${{ needs.UnitTestingParams.outputs.artifact_names }}
463462
artifact-json-ids: >-
@@ -470,11 +469,10 @@ jobs:
470469
- UnitTestingParams
471470
- Documentation
472471
if: >-
473-
${{ !failure() && !cancelled()
472+
!failure() && !cancelled()
474473
&& needs.Documentation.result == 'success'
475474
&& contains(inputs.documentation_steps, 'latex')
476475
&& contains(inputs.documentation_steps, 'pdf')
477-
}}
478476
with:
479477
document: ${{ needs.UnitTestingParams.outputs.package_fullname }}
480478
latex_artifact: ${{ fromJson(needs.UnitTestingParams.outputs.artifact_names).documentation_latex }}
@@ -493,13 +491,12 @@ jobs:
493491
- PublishCoverageResults
494492
- StaticTypeCheck
495493
if: >-
496-
${{ !failure() && !cancelled()
494+
!failure() && !cancelled()
497495
&& needs.Documentation.result == 'success'
498496
&& needs.PublishCoverageResults.result == 'success'
499497
&& needs.StaticTypeCheck.result == 'success'
500498
&& contains(inputs.documentation_steps, 'pages')
501499
&& needs.Prepare.outputs.publish_pages == 'true'
502-
}}
503500
with:
504501
doc: ${{ fromJson(needs.UnitTestingParams.outputs.artifact_names).documentation_html }}
505502
coverage: ${{ inputs.coverage_html == 'true' && fromJson(needs.UnitTestingParams.outputs.artifact_names).codecoverage_html || '' }}
@@ -518,11 +515,10 @@ jobs:
518515
- Install
519516
- PublishToGitHubPages
520517
if: >-
521-
${{ !failure() && !cancelled()
518+
!failure() && !cancelled()
522519
&& needs.Prepare.outputs.is_release_commit == 'true'
523520
&& needs.VersionCheck.result == 'success'
524521
&& github.event_name != 'schedule'
525-
}}
526522
permissions:
527523
contents: write # required for create tag
528524
actions: write # required for trigger workflow
@@ -544,10 +540,9 @@ jobs:
544540
- Install
545541
- PublishToGitHubPages
546542
if: >-
547-
${{ !failure() && !cancelled()
543+
!failure() && !cancelled()
548544
&& needs.Prepare.outputs.is_release_tag == 'true'
549545
&& needs.VersionCheck.result == 'success'
550-
}}
551546
permissions:
552547
contents: write
553548
actions: write
@@ -566,11 +561,10 @@ jobs:
566561
- Package
567562
- ReleasePage
568563
if: >-
569-
${{ !failure() && !cancelled()
564+
!failure() && !cancelled()
570565
&& needs.Package.result == 'success'
571566
&& needs.Prepare.outputs.is_release_tag == 'true'
572567
&& needs.VersionCheck.result == 'success'
573-
}}
574568
with:
575569
python_version: ${{ needs.UnitTestingParams.outputs.python_version }}
576570
requirements: '-r dist/requirements.txt'
@@ -601,9 +595,8 @@ jobs:
601595
- IntermediateCleanUp
602596
# !cancelled(), because PDFDocumentation is skipped without 'latex' and 'pdf' in documentation_steps
603597
if: >-
604-
${{ !cancelled()
598+
!cancelled()
605599
&& inputs.cleanup == 'true'
606-
}}
607600
with:
608601
json: ${{ needs.UnitTestingParams.outputs.artifact_names }}
609602
artifact-json-ids: >-

‎.github/workflows/Pipeline.yml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,10 @@ jobs:
3434
needs:
3535
- Prepare
3636
if: >-
37-
${{ needs.Prepare.outputs.on_dev_branch == 'true'
37+
needs.Prepare.outputs.on_dev_branch == 'true'
3838
|| needs.Prepare.outputs.on_main_branch == 'true'
3939
|| startsWith(needs.Prepare.outputs.branch, 'r')
4040
|| startsWith(needs.Prepare.outputs.branch, 'update/r')
41-
}}
4241
4342
steps:
4443
- name: ⏬ Checkout repository

0 commit comments

Comments
 (0)