Repository navigation
Make the zarr DataTree latency benchmark report changes - #11812
Merged
Merged
Conversation
With repeat = 3 every commit gets 6 samples, for which asv's Mann-Whitney test can never reach its p < 0.002 threshold, so the speedup of pydata#10742 was not reported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
headtr1ck
changed the title
headtr1ck
enabled auto-merge (squash)
October 26, 2026 14:50
Contributor
🥱 No significant changes. Boring, in the best possible way.Comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #11810: use
repeat = 1inIOReadDataTreeZarrLatency, so asv can report changes in it, and drop the 21 groups case.repeat = 3, every commit gets 6 samples (2 processes). For 6 vs 6 samples, asv's two-sided Mann-Whitney test can at best reach p ≈ 0.00216, above itsp < 0.002threshold, so no change is ever reported. In the benchmark run of #10742, the ~1.9x speedup was marked as not significant (~0.52) and left out of the comment.repeat = 1(2 samples per commit), asv compares the 99% confidence intervals instead, which flags that speedup (checked with asv'scompute_statsandis_different). It is also cheaper.AI Disclosure
Tools: Claude Code
🤖 Generated with Claude Code