Add hook for zeroconf - #1024
Open
Mirochill wants to merge 1 commit into
Open
Conversation
Mirochill
marked this pull request as ready for review
May 26, 2026 20:00
rokm
reviewed
May 26, 2026
| @@ -0,0 +1 @@ | |||
| Update ``zeroconf`` hook to collect cythonized package submodules. | |||
Member
There was a problem hiding this comment.
The hook was added, not updated. So the news fragment should be 1024.new.rst, and the message itself should reflect that.
rokm
reviewed
May 26, 2026
| import zeroconf | ||
|
|
||
| print(zeroconf.__name__) | ||
| """) |
Member
There was a problem hiding this comment.
This test passes with PyInstaller >= 6.13 even without the hook being added - presumably thanks to pyinstaller/pyinstaller#9084 and .py files being available next to the cythonized extensions.
Which means this PR should be largely redundant, except for people who are sticking to older versions of PyInstaller for whatever reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zeroconfthat collects package submodules hidden behind cythonized wheels.zeroconfin the test-library requirements.Closes #840.
Validation
Lint,Validate news entries, andPull Request CIrun https://github.com/pyinstaller/pyinstaller-hooks-contrib/actions/runs/26470820095.git diff --check,git diff --cached --check, andgit show --check --stat --oneline HEAD.