Skip to content

variable selection API differs between InstrumentalVariableRegression and StateSpaceTimeSeries #1176

Description

@anevolbap

InstrumentalVariableRegression takes vs_prior_type and vs_hyperparams as fit/build_model arguments, so the InstrumentalVariable experiment stores both and forwards them through a # type: ignore[call-arg,union-attr] call that bypasses the model adapter. StateSpaceTimeSeries (#1112) takes the same two arguments in __init__: the prior type is validated at construction and InterruptedTimeSeries needs no forwarding, since experiments only call fit(X, y, coords) through the adapter.

Should the IV class move to constructor configuration too, so the experiment stops forwarding model kwargs around the adapter contract?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions