Skip to content

fix: keep plot_ate axes as a list so the panels type-check #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anevolbap wants to merge 1 commit into from
Open

fix: keep plot_ate axes as a list so the panels type-check #1146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions causalpy/experiments/inverse_propensity_weighting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,8 +669,9 @@ def _make_hists(i, axs, method=method):
mosaic = """AAAAAA
BBBBCC"""

fig, axs = plt.subplot_mosaic(mosaic, figsize=(20, 13))
axs = [axs[k] for k in axs]
fig, mosaic_axes = plt.subplot_mosaic(mosaic, figsize=(20, 13))
# Keyed by mosaic label; the panels are used positionally from here on.
axs = [mosaic_axes[k] for k in mosaic_axes]
axs[0].axvline(
0.1, linestyle="--", label="Low Extreme Propensity Scores", color="black"
)
Expand Down
5 changes: 1 addition & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,13 +235,10 @@ ignore_missing_imports = true
warn_unused_configs = true

# Allowlist of modules that already fail, so the gate starts green and ratchets down (49 errors in 16 files, measured on pymc6_and_pymcmarketing1_migration at 194343ca). Each entry disables only the error codes that module actually produces, so everything else is still checked there. Removing an entry, or a single code from one, is a self-contained follow-up PR.
[[tool.mypy.overrides]]
module = "causalpy.experiments.inverse_propensity_weighting"
disable_error_code = ["arg-type", "assignment", "index", "return-value"]

[[tool.mypy.overrides]]
module = [
"causalpy.experiments.instrumental_variable",
"causalpy.experiments.inverse_propensity_weighting",
"causalpy.experiments.prepostnegd",
"causalpy.experiments.regression_discontinuity",
"causalpy.experiments.regression_kink",
Expand Down