Skip to content

Commit 4884028

Browse files
committed
Correct buffer_overrun test.
1 parent 09d363b commit 4884028

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

pymodbus/transport/transport.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,7 @@ def datagram_received(self, data: bytes, addr: tuple | None) -> None:
308308
self.recv_buffer += data
309309
if len(self.recv_buffer) > 1024:
310310
self.recv_buffer = b""
311+
return
311312
cut = self.callback_data(self.recv_buffer, addr=addr)
312313
self.recv_buffer = self.recv_buffer[cut:]
313314
if self.recv_buffer:

test/transport/test_protocol.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ async def test_datagram_buffer_overrun(self, client):
142142
client.callback_data = mock.MagicMock(return_value=0)
143143
client.recv_buffer = bytearray([0x01] * 2000)
144144
client.datagram_received(b"abc", "127.0.0.1")
145-
assert client.recv_buffer == b"abc"
145+
assert client.recv_buffer == b""
146146

147147
async def test_callback_connected(self, use_clc, dummy_protocol):
148148
"""Test callbacks."""

0 commit comments

Comments
 (0)