Repository navigation
Jules - fix sysinstall testing - #5181
Merged
Merged
Conversation
New implementation is simpler and does not attempt to support multiple configurations (with/without sudo, with/without venv etc). Instead we only test a simple user-mode installation root directory without use of a venv. This is close to real system installs, and avoids problems where running in a venv breaks mupdf's install location.
We modify the `pip install` command if sysinstall, so that we install into sysinstall's test directory. Also don't install/upgrade pytest itself.
This avoids the need to specify pytest excludes in scripts/sysinstall.py.
JorjMcKie
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated packaging docs.