Repository navigation
fix: keep zero-width chars in table cells when origin is inside - #5186
Open
fahmiridho07 wants to merge 1 commit into
Open
fahmiridho07 wants to merge 1 commit into
fahmiridho07 wants to merge 1 commit into
Conversation
With quad corrections unset (e.g. after importing pymupdf4llm), a glyph expanded into two characters gets a zero-width bbox for the second one. The 50%-overlap area test (0 > 0) then drops it, so table cells lose letters (fine-tuning -> fne-tuning). Fall back to testing the char origin for empty bboxes. Fixes pymupdf#5185
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5185.
With quad corrections unset (e.g. after importing pymupdf4llm, which calls
TOOLS.unset_quad_corrections(True)at import), a glyph expanded into two characters gets a zero-width bbox for the second one (e.g. theioffi:(151.70, 56.35, 151.70, 63.35)).extract_cellskeeps a char only ifabs(bbox & cell) > 0.5 * abs(bbox). For a zero-area bbox that is0 > 0, so the char is dropped and table cells lose letters (fine-tuning->fne-tuning,figures->fgures), while prose on the same page is fine. Same for zero-width combining overlays (i + U+0338->i = jloses the slash).This change falls back to testing the char origin for empty bboxes:
Verified locally with synthetic zero-width bboxes (pymupdf 1.28.0): old logic drops, new logic keeps inside-origin and still drops outside-origin, no change for normal chars.