Skip to content

tests(Updating value of test_parameter_optimization test) - #1096

Open
p-shg wants to merge 3 commits into
pyomeca:masterfrom
p-shg:master
Open

tests(Updating value of test_parameter_optimization test)#1096
p-shg wants to merge 3 commits into
pyomeca:masterfrom
p-shg:master

Conversation

@p-shg

@p-shg p-shg commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

@Ipuch

Ipuch commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

A parameter optimisation fails, one test.

FAILED tests/shard2/test_global_getting_started.py::test_parameter_optimization[COLLOCATION-PhaseDynamics.SHARED_DURING_THE_PHASE] - AssertionError: 
Arrays are not almost equal to 6 decimals
ACTUAL: np.float64(99.67117614751174)
DESIRED: 100.40019797776976

I've rerun the test locally, it failed again

It also fails in https://github.com/pyomeca/bioptim/actions/runs/33087431772/job/98570832348?pr=1049

I've checked the diff of the the conda env with the last merged PR: https://github.com/pyomeca/bioptim/actions/runs/29935117185/job/88974571114

Nothing much to note appart from :

  • numpy 2.5.2, instead of 2.5.1
  • casadi same version
  • python 3.14.7 instead of 3.14.6

I propose to change the value of the test @EveCharbie and @pariterre what do you think ?

@EveCharbie

Copy link
Copy Markdown
Collaborator

Ok for me :)

@pariterre

Copy link
Copy Markdown
Member

If it is okay for @EveCharbie , it is for me too :)

@Ipuch

Ipuch commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

@p-shg let's change the value of the test, renaming the title of the PR, and merge this PR.

@p-shg p-shg changed the title Dummy commit to run tests Updating value of test_parameter_optimization test Sep 4, 2026
@Ipuch Ipuch changed the title Updating value of test_parameter_optimization test tests(Updating value of test_parameter_optimization test) Sep 4, 2026
Note that value for initial torque changed significantly
@p-shg

p-shg commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

I changed values of the failing test. Most changes are marginal. Note that value for initial torque changed quite significantly
Waiting for tests for other OS to run on CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants