Repository navigation
Refactor spin-flip TDDFT - #178
Merged
Merged
Conversation
Contributor
|
Thanks for the fix. For collinear functional, i think it may be easier to understand if using gpu4pyscf's definition: |
Contributor
Author
Thanks for the suggestion! That would indeed be more consistent with gpu4pyscf. For the current refactor, I would keep the |
sunqm
approved these changes
Feb 14, 2026
Merged
jeanwsr
reviewed
Feb 14, 2026
|
|
||
| def _gen_uhf_tda_response_sf(mf, mo_coeff=None, mo_occ=None, hermi=0, collinear_samples=200, max_memory=None): | ||
| '''Generate a function to compute the product of Spin Flip UKS response function | ||
| Generate a function to compute the product of Spin-flip UKS response function |
Contributor
There was a problem hiding this comment.
Suggested change
| Generate a function to compute the product of Spin-flip UKS response function | |
| Generate a function to compute the product of Spin-flip UHF/UKS response function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the SF-TDDFT and SF-TDA modules to improve compatibility, functionality, and code structure.
Changes include:
max_spaceparameter with recent PySCF versions.collinear_samples < 0.pickeigfunction for SF-TDA and SF-TDDFT; thepositive_eig_thresholdparameter is no longer needed.NOTE: It addresses the compatibility issue mentioned in #173 but with more modifications.