Repository navigation
Remove Python 3.8 support - #224
Open
MatthewRHermes wants to merge 1 commit into
Open
MatthewRHermes wants to merge 1 commit into
MatthewRHermes wants to merge 1 commit into
Conversation
Follow pyscf/pyscf#3500: test Python 3.9 in CI instead of 3.8, and declare python_requires='>=3.9' so pip on 3.8 no longer picks up new pyscf-forge releases. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows pyscf/pyscf#3500, which dropped Python 3.8 from PySCF core.
Changes
ci.yml: thelinux-buildmatrix tests 3.9 instead of 3.8 (now 3.9, 3.10, 3.12).setup.py: addpython_requires='>=3.9'. pyscf-forge didn't declare a minimum Python before, so pip on 3.8 would still install new releases. Afterwards, pip on 3.8 stays on pyscf-forge 1.1.1.Nothing else in the repo assumes 3.8. The lint jobs and the manylinux wheel build in
publish.ymlalready use 3.9, and there are nosys.version_infoshims for 3.8.pyscf.afqmckeeps its own 3.10+ requirement.This should also retire the intermittent
linux-build (3.8)segfault inoccri/test/test_regression.py(inside LAPACK?sygvdviascipy.linalg.eigh,_decomp.py:577). That crash has only been seen on the 3.8 leg, wherescipy<1.16resolves to scipy 1.10.1 / numpy 1.24.4.No conflicts with #221 or #223: the three PRs touch disjoint files.
Code changes and this description were drafted with the assistance of Claude Opus 5.5.
🤖 Generated with Claude Code