Deprecate/drop support for accepting bytes in terminal.write_line #7323

Activity

1. nicoddemus

   added

   type: deprecationfeature that will be removed in the futurefeature that will be removed in the future

   on Jun 5, 2020
2. nicoddemus

   added this to the 7.0 milestone on Jun 5, 2020
3. avats-dev commented on Oct 3, 2020

   

   avats-dev

   on Oct 3, 2020

   More actions

   @nicoddemus Also this one too, can you help out a bit? I think I have to add DeprecationWarning here

   pytest/src/_pytest/terminal.py

   Lines 424 to 428 in 133e8af

   	def write_line(self, line: Union[str, bytes], **markup: bool) -> None:
   	if not isinstance(line, str):
   	line = str(line, errors="replace")
   	self.ensure_newline()
   	self._tw.line(line, **markup)

   , right?
4. nicoddemus commented on Oct 4, 2020

   

   nicoddemus

   on Oct 4, 2020

   MemberAuthor

   More actions

   Hi @avats-dev,

   Thanks for the offer!

   Generally yes, but the process is a bit more involved:

   • Add the warning message in src/_pytest/deprecated.py.
   • Add a test in testing/deprecated_test.py.
   • Issue the warning in the location you posted.
   • Add a CHANGELOG entry style deprecation.
   • Add yourself to authors.

   I might have forgotten something, but don't hesitate in open the PR, we can discuss last minute changes there. 👍
5. avats-dev commented on Oct 4, 2020

   

   avats-dev

   on Oct 4, 2020

   More actions

   Ok @nicoddemus , thanks for the insights. I'll open a PR soon with the changes. Also, we're deprecating here but we can also drop this as mentioned in the issue, so would that be alright?
6. nicoddemus commented on Oct 4, 2020

   

   nicoddemus

   on Oct 4, 2020

   MemberAuthor

   More actions

   ... but we can also drop this as mentioned in the issue, so would that be alright?

   Our policy is to deprecate it first and only drop it in the next major release, so we really should deprecate it first. 👍

   👍React with 👍1Reacted by Aditya Vats
7. bluetech

   modified the milestones: 8.0, 9.0 on Jan 16, 2024
8. bluetech

   modified the milestones: 9.0, 10.0 on Nov 5, 2025
9. LuanaPBueno

   added a commit that references this issue on Oct 18, 2026

   Deprecate passing bytes to TerminalReporter.write_line

   ...

   This issue will close once commit bcd2548 is merged into the 'main' branch.

   bcd2548
10. LuanaPBueno commented on Oct 18, 2026

    

    LuanaPBueno

    on Oct 18, 2026

    More actions

    Opened pytest-dev/pytest#15202 for this, following the steps above.