Repository navigation
Deprecate passing bytes to TerminalReporter.write_line - #15202
Open
LuanaPBueno wants to merge 2 commits into
Open
LuanaPBueno wants to merge 2 commits into
LuanaPBueno wants to merge 2 commits into
Conversation
Closes pytest-dev#7323 Co-authored-by: Claude <noreply@anthropic.com>
RonnyPfannschmidt
requested changes
Oct 18, 2026
| ) | ||
|
|
||
| TERMINAL_WRITE_LINE_BYTES = PytestRemovedIn10Warning( | ||
| "Passing bytes to TerminalReporter.write_line() is deprecated, pass a str instead.\n" |
Member
There was a problem hiding this comment.
please use unformattedwarnings
there's a structural issue with -W error triggering problems with the gc if a warning is reused again and again
Author
There was a problem hiding this comment.
Thanks! Switched to UnformattedWarning! Can you review for me, please?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deprecates passing bytes to TerminalReporter.write_line(), following the steps nicoddemus described in pytest-dev/pytest#7323. Bytes are still decoded for now, so nothing breaks until pytest 10. I used Claude to help, and reviewed and tested the changes myself.
Closes #7323
closes #XYZWto the PR description and/or commits.Co-authored-bycommit trailers.changelogdirectory.AUTHORSin alphabetical order.