perf: lazy proxy classes for O(1) property access (SimplicesProxy, VertexToSimplicesProxy, VerticesProxy)

Author: basnijholt

.pre-commit-config.yaml

@@ -20,6 +20,7 @@ repos:
       - id: mypy
         additional_dependencies: [numpy]
         args: [--strict]
+        exclude: '(\.pyi$|tests/)'
   - repo: local
     hooks:
       - id: cargo-fmt

IMPLEMENTATION.md

@@ -177,59 +177,59 @@ Wraps `Triangulation`. All methods exposed to Python.
 ```python
 class Triangulation:
     def __init__(self, coords: np.ndarray) -> None: ...
-    
+
     def add_point(
         self,
         point: tuple[float, ...] | np.ndarray,
         simplex: tuple[int, ...] | None = None,
         transform: np.ndarray | None = None,
     ) -> tuple[set[tuple[int, ...]], set[tuple[int, ...]]]: ...
-    
+
     @property
     def vertices(self) -> list[tuple[float, ...]]: ...
-    
+
     @property
     def simplices(self) -> set[tuple[int, ...]]: ...
-    
+
     @property
     def vertex_to_simplices(self) -> list[set[tuple[int, ...]]]: ...
-    
+
     @property
     def hull(self) -> set[int]: ...
-    
+
     @property
     def dim(self) -> int: ...
-    
+
     def get_vertices(self, indices: tuple[int, ...]) -> list[tuple[float, ...]]: ...
-    
+
     def locate_point(self, point: tuple[float, ...] | np.ndarray) -> tuple[int, ...] | None: ...
-    
+
     def get_reduced_simplex(
         self, point: tuple[float, ...], simplex: tuple[int, ...], eps: float = 1e-8
     ) -> tuple[int, ...]: ...
-    
+
     def circumscribed_circle(
         self, simplex: tuple[int, ...], transform: np.ndarray | None = None
     ) -> tuple[tuple[float, ...], float]: ...
-    
+
     def point_in_circumcircle(
         self, pt_index: int, simplex: tuple[int, ...], transform: np.ndarray | None = None
     ) -> bool: ...
-    
+
     def volume(self, simplex: tuple[int, ...]) -> float: ...
-    
+
     def faces(
         self, dim: int | None = None, vertices: bool = False,
         simplices: set[tuple[int, ...]] | None = None,
     ) -> Iterator: ...
-    
+
     def containing(self, face: tuple[int, ...]) -> set[tuple[int, ...]]: ...
-    
+
     def reference_invariant(self) -> bool: ...
-    
+
     @property
     def default_transform(self) -> np.ndarray: ...
-    
+
     def point_in_simplex(self, point: tuple[float, ...], simplex: tuple[int, ...], eps: float = 1e-8) -> bool: ...
 ```
 
@@ -294,4 +294,4 @@ pip install maturin
 5. Working `maturin develop --release` build
 6. All tests passing
 
-When complete, write results to `.claude/REPORT.md`.
+When complete, write results to `.claude/REPORT.md`.

python/adaptive_triangulation/__init__.py

@@ -23,7 +23,11 @@
 from __future__ import annotations
 
 from ._rust import (
+    SimplicesProxy,
     Triangulation,
+    VertexToSimplicesProxy,
+    VerticesProxy,
+    __version__,
     circumsphere,
     fast_2d_circumcircle,
     fast_2d_point_in_simplex,
@@ -35,12 +39,12 @@
     simplex_volume_in_embedding,
     volume,
 )
-from ._rust import (
-    __version__ as __version__,
-)
 
 __all__: list[str] = [
+    "SimplicesProxy",
     "Triangulation",
+    "VertexToSimplicesProxy",
+    "VerticesProxy",
     "__version__",
     "circumsphere",
     "fast_2d_circumcircle",

python/adaptive_triangulation/__init__.pyi

@@ -1,6 +1,15 @@
+from ._rust import (
+    SimplicesProxy as SimplicesProxy,
+)
 from ._rust import (
     Triangulation as Triangulation,
 )
+from ._rust import (
+    VertexToSimplicesProxy as VertexToSimplicesProxy,
+)
+from ._rust import (
+    VerticesProxy as VerticesProxy,
+)
 from ._rust import (
     __version__ as __version__,
 )
@@ -36,7 +45,10 @@ from ._rust import (
 )
 
 __all__: list[str] = [
+    "SimplicesProxy",
     "Triangulation",
+    "VertexToSimplicesProxy",
+    "VerticesProxy",
     "__version__",
     "circumsphere",
     "fast_2d_circumcircle",

python/adaptive_triangulation/_rust.pyi

@@ -9,34 +9,43 @@ PointsLike: TypeAlias = Sequence[Sequence[float]] | npt.ArrayLike
 SimplexLike: TypeAlias = Sequence[int]
 Simplex: TypeAlias = tuple[int, ...]
 SimplexSet: TypeAlias = set[Simplex]
+CircumscribedCircle: TypeAlias = tuple[tuple[float, ...], float]
 TransformLike: TypeAlias = Sequence[Sequence[float]] | npt.ArrayLike
 
 __version__: str
 
+class SimplicesProxy:
+    def __contains__(self, simplex: Simplex) -> bool: ...
+    def __iter__(self) -> Iterator[Simplex]: ...
+    def __len__(self) -> int: ...
+
+class VerticesProxy:
+    def __getitem__(self, index: int) -> tuple[float, ...]: ...
+    def __iter__(self) -> Iterator[tuple[float, ...]]: ...
+    def __len__(self) -> int: ...
+
+class VertexToSimplicesProxy:
+    def __getitem__(self, index: int) -> SimplexSet: ...
+    def __iter__(self) -> Iterator[SimplexSet]: ...
+    def __len__(self) -> int: ...
 
 class Triangulation:
     def __init__(self, coords: PointsLike) -> None: ...
-
     @property
-    def vertices(self) -> list[tuple[float, ...]]: ...
-
+    def vertices(self) -> VerticesProxy: ...
     @property
-    def simplices(self) -> SimplexSet: ...
-
+    def simplices(self) -> SimplicesProxy: ...
     @property
-    def vertex_to_simplices(self) -> list[SimplexSet]: ...
-
+    def vertex_to_simplices(self) -> VertexToSimplicesProxy: ...
     @property
     def hull(self) -> set[int]: ...
-
     @property
     def dim(self) -> int: ...
-
     @property
     def default_transform(self) -> npt.NDArray[np.float64]: ...
-
     def add_simplex(self, simplex: SimplexLike) -> None: ...
     def delete_simplex(self, simplex: SimplexLike) -> None: ...
+    def has_simplex(self, simplex: Simplex) -> bool: ...
     def add_point(
         self,
         point: PointLike,
@@ -55,7 +64,7 @@ class Triangulation:
         self,
         simplex: SimplexLike,
         transform: TransformLike | None = None,
-    ) -> tuple[tuple[float, ...], float]: ...
+    ) -> CircumscribedCircle: ...
     def point_in_circumcircle(
         self,
         pt_index: int,
@@ -78,6 +87,7 @@ class Triangulation:
     ) -> Iterator[Simplex]: ...
     def containing(self, face: Sequence[int]) -> SimplexSet: ...
     def reference_invariant(self) -> bool: ...
+    def vertex_to_simplices_for(self, vertex: int) -> SimplicesProxy: ...
     def point_in_simplex(
         self,
         point: PointLike,
@@ -93,7 +103,6 @@ class Triangulation:
     def vertex_invariant(self, vertex: int) -> bool: ...
     def convex_invariant(self, vertex: int) -> bool: ...
 
-
 def circumsphere(points: PointsLike) -> tuple[tuple[float, ...], float]: ...
 def fast_2d_circumcircle(points: PointsLike) -> tuple[tuple[float, ...], float]: ...
 def fast_2d_point_in_simplex(point: PointLike, simplex: PointsLike, eps: float = 1e-8) -> bool: ...

python/adaptive_triangulation/py.typed

@@ -1 +0,0 @@
-

src/lib.rs

@@ -7,7 +7,8 @@ use pyo3::types::{PyAny, PyModule, PyTuple};
 
 use crate::geometry as geom;
 use crate::triangulation::{
-    parse_point, parse_points_sized, point_tuple, PyFacesIter, PyTriangulation,
+    parse_point, parse_points_sized, point_tuple, PyFacesIter, PySimplicesProxy, PyTriangulation,
+    PyVertexToSimplicesIter, PyVertexToSimplicesProxy, PyVerticesIter, PyVerticesProxy,
 };
 
 fn numpy_linalg_error(py: Python<'_>, message: &str) -> PyErr {
@@ -33,6 +34,11 @@ fn point_in_simplex_error(py: Python<'_>, err: geom::GeometryError) -> PyErr {
 fn _rust(m: &Bound<'_, PyModule>) -> PyResult<()> {
     m.add_class::<PyTriangulation>()?;
     m.add_class::<PyFacesIter>()?;
+    m.add_class::<PySimplicesProxy>()?;
+    m.add_class::<PyVerticesProxy>()?;
+    m.add_class::<PyVertexToSimplicesProxy>()?;
+    m.add_class::<PyVerticesIter>()?;
+    m.add_class::<PyVertexToSimplicesIter>()?;
     m.add("__version__", env!("CARGO_PKG_VERSION"))?;
 
     m.add_function(wrap_pyfunction!(py_circumsphere, m)?)?;