Skip to content

Commit 318888d

Browse files
tamsk-91hugovk
andauthored
Fix OverflowError in naturaltime/precisedelta for far-future dates (#479)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
1 parent d16e635 commit 318888d

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

‎src/humanize/time.py‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,7 @@ def _abs_timedelta(delta: dt.timedelta) -> dt.timedelta:
6161
Returns:
6262
datetime.timedelta: Absolute timedelta.
6363
"""
64-
if delta.days < 0:
65-
now = _now()
66-
return now - (now + delta)
67-
return delta
64+
return abs(delta)
6865

6966

7067
def _date_and_delta(

‎tests/test_time.py‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,8 @@ def test_naturaldelta_too_large_value_raises() -> None:
196196
(NOW - dt.timedelta(days=365 + 35), "1 year, 1 month ago"),
197197
(dt.timedelta(days=-10000), "27 years from now"),
198198
(dt.timedelta(days=365 + 35), "1 year, 1 month ago"),
199+
(dt.datetime(9999, 12, 31), "7,995 years from now"),
200+
(dt.timedelta(days=-800_000), "2,192 years from now"),
199201
(22.5, "22 seconds ago"),
200202
(23.5, "24 seconds ago"),
201203
(23.9, "24 seconds ago"),
@@ -645,6 +647,11 @@ def test_precisedelta_one_unit_enough(
645647
(dt.timedelta(days=32), "seconds", "1 month and 1 day"),
646648
(dt.timedelta(days=62), "seconds", "2 months and 1 day"),
647649
(dt.timedelta(days=92), "seconds", "3 months"),
650+
(
651+
dt.timedelta(days=-800_000),
652+
"seconds",
653+
"2,191 years, 9 months and 10 days",
654+
),
648655
(dt.timedelta(days=31), "days", "1 month"),
649656
(dt.timedelta(days=32), "days", "1 month and 1 day"),
650657
(dt.timedelta(days=62), "days", "2 months and 1 day"),

0 commit comments

Comments
 (0)