Skip to content

README: fix the new locale catalog path - #445

Merged
hugovk merged 1 commit into
python-humanize:mainfrom
xiehuanyi:docs/current-locale-source-paths
Nov 12, 2026
Merged

hugovk merged 1 commit into
python-humanize:mainfrom
xiehuanyi:docs/current-locale-source-paths

Conversation

@xiehuanyi

Copy link
Copy Markdown
Contributor

The README new-locale command writes to humanize/locale, although the source checkout stores catalogs under src/humanize/locale. It also requires the destination directory to exist.

Changes proposed in this pull request:

  • Use the current source-catalog path in msginit.
  • Create the new locale’s LC_MESSAGES directory before generating the catalog.

Validation: in an isolated temporary checkout, reproduced msginit failing on the old output path. Executed the corrected README commands with cs_CZ and --no-translator for noninteractive validation; the catalog was created at the source path and passed msgfmt --check. Generated existing translation binaries and ran the full suite: 854 passed, 2 skipped. prek run --all-files passes.

AI assistance: prepared and verified with OpenAI Codex.

Copilot AI balanced review requested due to automatic review settings October 7, 2026 10:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@hugovk
hugovk force-pushed the docs/current-locale-source-paths branch from 3414ffc to 0c0c9a9 Compare November 12, 2026 09:26
@hugovk hugovk added documentation Improvements or additions to documentation changelog: Fixed For any bug fixes labels Nov 12, 2026
@hugovk hugovk changed the title docs: fix the new locale catalog path README: fix the new locale catalog path Nov 12, 2026
@hugovk hugovk added changelog: skip Exclude PR from release draft and removed changelog: Fixed For any bug fixes labels Nov 12, 2026
@hugovk
hugovk enabled auto-merge (squash) November 12, 2026 09:26
@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.70%. Comparing base (318888d) to head (0c0c9a9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          12       12           
  Lines        1021     1021           
=======================================
  Hits         1018     1018           
  Misses          3        3           
Flag Coverage Δ
macos-latest 97.25% <ø> (ø)
ubuntu-latest 97.25% <ø> (ø)
windows-latest 91.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugovk
hugovk merged commit 16a4a16 into python-humanize:main Nov 12, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: skip Exclude PR from release draft documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants