Repository navigation
Fix OverflowError in naturaltime/precisedelta for far-future dates - #479
Merged
Merged
Conversation
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
- Coverage 99.70% 99.70% -0.01%
==========================================
Files 12 12
Lines 1024 1021 -3
==========================================
- Hits 1021 1018 -3
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Nov 12, 2026
hugovk
reviewed
Nov 12, 2026
hugovk
changed the title
OverflowError in naturaltime/precisedelta for far-future dates
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an OverflowError in naturaltime() and precisedelta() for far-future dates such as datetime(9999, 12, 31) by using abs(delta) in _abs_timedelta(). Adds regression tests.