Skip to content

Reject out-of-range UTC offsets in the pure-Python parsers #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sharadhi-v98 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Reject out-of-range UTC offsets in the pure-Python parsers #1015

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f98025b
Reject out-of-range UTC offsets in the pure-Python parsers
Sharadhi-v98 Sep 23, 2026
33843aa
Clarify out-of-range offset error messages
Sharadhi-v98 Sep 26, 2026
12e3e64
Reject out-of-range UTC offsets in the Rust parser too
Sharadhi-v98 Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/pendulum/formatting/formatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,9 @@ def _get_parsed_value(

offset = ((int(off_hour) * 60) + int(off_minute)) * 60

if abs(offset) >= 24 * 3600:
raise ValueError("Invalid date: timezone offset is out of range")

if negative:
offset = -1 * offset

Expand Down
3 changes: 3 additions & 0 deletions src/pendulum/parsing/iso8601.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,9 @@ def parse_iso8601(

offset = ((int(off_hour) * 60) + int(off_minute)) * 60

if abs(offset) >= 24 * 3600:
raise ParserError("Invalid ISO 8601 timezone offset")

if negative:
offset = -1 * offset

Expand Down
7 changes: 7 additions & 0 deletions tests/datetime/test_from_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,13 @@ def test_from_format_with_invalid_padded_day():
pendulum.from_format("Apr 2 12:00:00 2020 GMT", "MMM DD HH:mm:ss YYYY z")


def test_from_format_with_out_of_range_offset():
with pytest.raises(ValueError):
pendulum.from_format("1975-05-21 22:32:11 +9959", "YYYY-MM-DD HH:mm:ss ZZ")
with pytest.raises(ValueError):
pendulum.from_format("1975-05-21 22:32:11 +24:00", "YYYY-MM-DD HH:mm:ss Z")


@pytest.mark.parametrize(
"text,fmt,expected,now",
[
Expand Down
8 changes: 8 additions & 0 deletions tests/parsing/test_parse_iso8601.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,14 @@ def test_parse_iso8601_invalid():
with pytest.raises(ValueError):
parse_iso8601("2009-05-19 14:39:22+0:6:00")

# Offset out of range (>= 24h)
with pytest.raises(ValueError):
parse_iso8601("2016-10-16T12:34:56+99:59")
with pytest.raises(ValueError):
parse_iso8601("2016-10-16T12:34:56-2400")
with pytest.raises(ValueError):
parse_iso8601("2016-10-16T12:34:56+2400")

# Missing time separator
with pytest.raises(ValueError):
parse_iso8601("2009-05-1914:39")
Expand Down
Loading