[kenttonino]

Summary

• Fixes Poetry shell command does not start shell #21
• If we have a newly created shell, then deactivate, then activate the shell again, it will only show a message that Virtual environment already activated, but its not activated.
  • The problem is that we only check if the POETRY_ACTIVE is set, but not the VIRTUAL_ENV.

Changes

• command.py:
  • If the POETRY_ACTIVE is set but not the VIRTUAL_ENV, pop the POETRY_ACTIVE.

Test Plan

Test 1

• Create shell.
• Deactivate the shell.
• Activate again the shell.
  • It should activate the shell.

Test 2

• Activate the shell.
• Then, activate again.
  • It should show Virtual environment already activated.

[kenttonino]

Thanks for the feedback @StantonMatt. Will add additional test case.

[kenttonino]

Hello @StantonMatt. Done adding the test case for stale POETRY_ACTIVE without VIRTUAL_ENV path. Kindly check if available. Thanks.

Also tested on my machine:

ProductName:		macOS
ProductVersion:		26.5.1
BuildVersion:		25F80

[yangfan-yf-yf]

I reviewed the current head 96ebc6b independently. The new regression test now directly covers the stale state: with POETRY_ACTIVE=1 and no VIRTUAL_ENV, the command invokes Shell.activate() instead of reporting an already-active environment. The existing active-environment test explicitly provides VIRTUAL_ENV and retains the early-return behavior.

Local verification on Windows with Python 3.12:

• python -m pytest -q — 18 passed
• git diff --check

The GitHub Ubuntu, macOS, and Windows matrix is also green on the current head. The local Ruff and MyPy commands still report findings in unchanged shell.py and tests/conftest.py, respectively; they are outside this PR's diff.

[kenttonino]

Thanks @yangfan-yf-yf. Will take a look on this one. However, the fix will be on a separate PR.

I reviewed the current head 96ebc6b independently. The new regression test now directly covers the stale state: with POETRY_ACTIVE=1 and no VIRTUAL_ENV, the command invokes Shell.activate() instead of reporting an already-active environment. The existing active-environment test explicitly provides VIRTUAL_ENV and retains the early-return behavior.

Local verification on Windows with Python 3.12:

• python -m pytest -q — 18 passed
• git diff --check

The GitHub Ubuntu, macOS, and Windows matrix is also green on the current head. The local Ruff and MyPy commands still report findings in unchanged shell.py and tests/conftest.py, respectively; they are outside this PR's diff.