Repository navigation
Forward modulus arguments in Float power methods - #691
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward the modulus argument from
Float.__pow__andFloat.__rpow__to Python's native float methods.Currently
pow(item(2.0), 3, 3)returns8.0, silently ignoring the modulus. The equivalent native-float call raisesTypeError, because modular exponentiation is supported only for integers. Forwarding the argument preserves that native error rather than returning an unrelated numeric result. Two-argument powers and an explicitNonemodulus retain their existing behavior.Duplicate Check
Integerpower result types. This change is limited to forwarding arguments in the separateFloatmethods and does not modifyIntegerpowers.Validation
None-modulus controls pass.toml-testsubmodule checked out.git diff --checkpass for the changed files.Agent Drafting Metadata