Repository navigation
Conversation
python-poetry#658 fixed python-poetry#655 (an escape=False multiline string with a leading newline got an extra blank line), but no test covers it: with the items.py part of python-poetry#658 taken out, the whole suite still passes. Add the two cases from the issue to test_create_string. Both fail without the fix and pass with it. Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#658 fixed #655 (a multiline string built with
escape=Falsewhose value starts with a newline got an extra blank line after the opening quotes). The merged fix has no test: with thetomlkit/items.pypart of #658 taken out, the whole test suite still passes.This adds the two cases from #655 to
test_create_string, one basic and one literal multiline string. Both fail without the fix and pass with it. #656 (closed in favour of #658) had similar tests; this brings that coverage back on top of the merged fix.I used Claude Code to run
python -m pytest(1226 passed), plusruff checkandruff format --checkon the changed file.Adds the missing test for #655.
Duplicate Check
Agent Drafting Metadata