Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
round()withoutndigits(or withNone) should return an integer for a float, butFloat.__round__defaults to zero digits and returns anotherFloat. A value read from TOML therefore fails where the equivalent rounded native float works:Distinguish omitted/
Nonedigits from an explicit digit count, wrapping the native integral result asIntegerwith copied trivia. Explicit digit counts still produceFloat, including zero. This also restores the native errors for rounding infinities and NaN without digits.Validation on Windows / CPython 3.12.10:
git diff --checkpass.Tests cover ties-to-even, both signs, omitted/
None/direct invocation, explicit digit counts, nonfinite errors, and comment/sign preservation.Duplicate Check
__round__searches before submission. Related open PRs Preserve floating-point results of negative integer powers #640 and Forward modulus arguments in Float power methods #691 concern power methods, not rounding; this change does not modify them.Agent Drafting Metadata