Repository navigation
Conversation
|
✅ Human Attestation: @pasmud attested this PR at commit
Later pushes to this PR stay attested. Attestation page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Assigning a non-table value to an array of tables currently succeeds, but dumping the document then raises an AttributeError. For example,
doc['a'][0] = 42leaves a scalar where the renderer expects a table.Validate converted integer and slice replacements before updating either storage representation. Reject non-table values with ValueError, matching the validation already used by AoT.insert. Failed assignments leave the document unchanged.
Validation: all 20 regression cases fail against unchanged source. With the fix, all 1,455 tests pass on Windows / Python 3.13.1 with
python -m pytest -q --override-ini addopts='', including the pinned toml-test compliance cases. Ruff 0.17.4 lint and formatting checks pass for both changed files, as doesgit diff --check. Before the final test expansion, Mypy 1.19.1 reported the same 33 diagnostics in eight files on the patch and unchanged source checked using shadow files, allowing for shifted line numbers. No successful type check, other operating systems or upstream CI results are claimed.Duplicate Check
Agent Drafting Metadata
Human Attestation
Attestation supplied by the submitting contributor: