Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tests/test_items.py
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,24 @@ def test_aot_integer_assignment_updates_list_storage() -> None:
assert parse(doc.as_string()).unwrap() == doc.unwrap()


@pytest.mark.parametrize(
"index", [0, -1, slice(None), slice(None, None, 2), slice(None, None, -2)]
)
@pytest.mark.parametrize("invalid", [42, "text", [1, 2], api.inline_table()])
def test_aot_assignment_rejects_non_tables_without_mutation(
index: int | slice, invalid: Any
) -> None:
source = "[[a]]\nx = 1\n[[a]]\nx = 2\n[[a]]\nx = 3\n"
doc = parse(source)
replacement = [{"x": 3}, invalid] if isinstance(index, slice) else invalid
with pytest.raises(ValueError, match="Unsupported assignment value type"):
doc["a"][index] = replacement
assert doc.as_string() == source
assert doc["a"] == [{"x": 1}, {"x": 2}, {"x": 3}]
assert doc.unwrap() == {"a": [{"x": 1}, {"x": 2}, {"x": 3}]}
assert json.loads(json.dumps(doc)) == doc.unwrap()


def test_aot_delete_after_slice_insertion() -> None:
doc = parse("[[a]]\nx = 1\n")
doc["a"][1:1] = [{"x": 2}]
Expand Down
7 changes: 7 additions & 0 deletions tomlkit/items.py
Original file line number Diff line number Diff line change
Expand Up @@ -2445,8 +2445,15 @@ def __getitem__(self, key: int | slice) -> Table | list[Table]:
def __setitem__(self, key: slice | int, value: Any) -> None: # type: ignore[override]
if isinstance(key, slice):
value = [item(v, _parent=self) for v in value]
for table in value:
if not isinstance(table, Table):
raise ValueError(
f"Unsupported assignment value type: {type(table)}"
)
else:
value = item(value, _parent=self)
if not isinstance(value, Table):
raise ValueError(f"Unsupported assignment value type: {type(value)}")
self._body[key] = value
list.__setitem__(self, key, value)

Expand Down
Loading