Repository navigation
Avoid SSL tests on x86 Windows as cryptography doesn't support it - #3515
Merged
A5rocks merged 2 commits intoSep 30, 2026
Merged
Conversation
A5rocks
force-pushed
the
avoid-cryptography-x86-windows
branch
from
September 17, 2026 03:21
905c160 to
cb0a778
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3515 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 128 128
Lines 19454 19474 +20
Branches 1321 1323 +2
===============================================
+ Hits 19454 19474 +20
🚀 New features to boost your workflow:
|
CoolCat467
reviewed
Sep 17, 2026
A5rocks
force-pushed
the
avoid-cryptography-x86-windows
branch
from
September 17, 2026 05:10
40cba89 to
92e17e1
Compare
CoolCat467
approved these changes
Sep 30, 2026
CheViana
pushed a commit
to CheViana/trio
that referenced
this pull request
Oct 1, 2026
angelancajas98-droid
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3466
This is actually somewhat similar to #3468 since it turns out
cryptographydoesn't ship wheels for x86 windows anymore (wow! unbelievable!), and so we try building it and that fails since it's Windows. Either we can figure out all the right environment (e.g. have openssl), or we can avoid installingcryptography. (I may want to rename the environment variable we check, too.)Additionally, we cannot avoid installing
cryptographyusing environment markers, sinceplatform_machineis for the machine rather than the build of Python, and the environment markers are in general exactly the same.The upside is that this makes the actual skipping logic extremely simple!