Skip to content

Avoid SSL tests on x86 Windows as cryptography doesn't support it - #3515

Merged
A5rocks merged 2 commits into
python-trio:mainfrom
A5rocks:avoid-cryptography-x86-windows
Sep 30, 2026
Merged

A5rocks merged 2 commits into
python-trio:mainfrom
A5rocks:avoid-cryptography-x86-windows

Conversation

@A5rocks

@A5rocks A5rocks commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Fixes #3466

This is actually somewhat similar to #3468 since it turns out cryptography doesn't ship wheels for x86 windows anymore (wow! unbelievable!), and so we try building it and that fails since it's Windows. Either we can figure out all the right environment (e.g. have openssl), or we can avoid installing cryptography. (I may want to rename the environment variable we check, too.)

Additionally, we cannot avoid installing cryptography using environment markers, since platform_machine is for the machine rather than the build of Python, and the environment markers are in general exactly the same.

The upside is that this makes the actual skipping logic extremely simple!

@A5rocks
A5rocks force-pushed the avoid-cryptography-x86-windows branch from 905c160 to cb0a778 Compare September 17, 2026 03:21
@codecov

codecov Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (59d94d7) to head (92e17e1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3515   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             128          128           
  Lines           19454        19474   +20     
  Branches         1321         1323    +2     
===============================================
+ Hits            19454        19474   +20     
Files with missing lines Coverage Δ
src/trio/_tests/pytest_plugin.py 100.00000% <100.00000%> (ø)
src/trio/_tests/test_dtls.py 100.00000% <100.00000%> (ø)
src/trio/_tests/test_exports.py 100.00000% <100.00000%> (ø)
src/trio/_tests/test_ssl.py 100.00000% <100.00000%> (ø)
src/trio/_tests/tools/test_gen_exports.py 100.00000% <100.00000%> (ø)
src/trio/_tests/tools/test_sync_requirements.py 100.00000% <100.00000%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread ci.sh Outdated
Comment thread ci.sh
@A5rocks
A5rocks force-pushed the avoid-cryptography-x86-windows branch from 40cba89 to 92e17e1 Compare September 17, 2026 05:10
@A5rocks
A5rocks requested a review from CoolCat467 September 30, 2026 02:14
@A5rocks
A5rocks merged commit ada9c77 into python-trio:main Sep 30, 2026
92 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't run SSL tests on Windows x86

3 participants