Repository navigation
test: dedupe source helpers and cover inherited cooldown - #1465
qiaobochi040726-source wants to merge 1 commit into
Conversation
…ooldown Move _configure_package() and _source_yaml() from three test modules into conftest so the hook-prebuilt schema rule only lives in one place. Add a case for a source: package with no min_release_age, which should fall back to the global --min-release-age. Also assert the whole GitLab server URL, which turned up a real bug: the port came out as 'None' when project_url had no explicit port, so default it to 443. Signed-off-by: qiaobochi040726-source <qiaobochi040726-source@users.noreply.github.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Tick the box to add this pull request to the merge queue (same as
|
|
Thanks! The test cleanups look good. A few changes:
|
LalatenduMohanty
left a comment
There was a problem hiding this comment.
Requesting changes per my comment above: #1465 (comment)
Moved the three copies of
_configure_package()/_source_yaml()into conftest, so the hook-prebuilt schema rule only gets maintained in one place. Added a test for asource:package withoutmin_release_age, which should fall back to the global--min-release-age.Asserting the whole GitLab server URL turned up a real bug: the port came out as
Nonewhenproject_urlhad no explicit port, so it now defaults to 443. The bug fix is the one line in_resolver.py; everything else is tests.pytest tests/before and after: same 38 failures both ways (Windows: git VCS URLs with backslash paths,sys.abiflags), plus the new test passing. ruff and mypy are clean apart from the same pre-existing windows errors.closes #1424