Skip to content

fix(bootstrap): discover dependencies of cached top-level versions - #1468

Open
vshawrh wants to merge 1 commit into
mainfrom
fix/cached-top-level-build-dependencies
Open

vshawrh wants to merge 1 commit into
mainfrom
fix/cached-top-level-build-dependencies

Conversation

@vshawrh

@vshawrh vshawrh commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

In multiple-version bootstrap, cached top-level versions were left in graph.json without build edges and omitted from build-order.json. A later cache miss made build-parallel rebuild these nodes in round 1, before their build backends were available in the local binary-only index.

Retain cached top-level versions for dependency discovery. The existing cached-wheel preparation path reads recorded requirements from the wheel, and the build phase reuses that wheel. Cache filtering of transitive dependency versions is preserved. This trades additional metadata/dependency processing for a complete build graph; it does not serialize builds or force recompilation of cache hits.

The regression uses two cached wheel archives with different backend requirements. It checks metadata reuse without source downloads or wheel compilation and verifies that both backends are scheduled before their applications when the remote cache is subsequently unavailable. A parameterized test also covers mixed cached and uncached top-level versions while preserving transitive cache filtering.

Validation: 234 bootstrap, graph and requirement resolver tests passed; Ruff check, Ruff format check and git diff --check passed. The new regression fails on unmodified upstream main. Production bootstrap timing and the affected wheel builds still need CI validation.

Related to RHAI-7566, RHAI-22532 and RHAI-22533. RHAI-44490 is a possible additional consumer, but its historical graph artifacts are expired and this PR does not claim to resolve it. Fondue must adopt a released Fromager version containing this change before its pipeline tickets can be validated and closed.

Co-Authored-By: Codex GPT-6 noreply@openai.com
Signed-off-by: Vikash Shaw vshaw@redhat.com

Retain build edges for cached top-level versions so later cache misses rebuild in dependency order (RHAI-7566, RHAI-22532, RHAI-22533).

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Signed-off-by: Vikash Shaw <vshaw@redhat.com>
@vshawrh
vshawrh requested a review from a team as a code owner November 16, 2026 04:10
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Resolve retains cached top-level versions for Start processing and skips cached dependency versions. Tests verify that cached wheels are reused, build-system metadata restores backend build edges, and expected resolved versions depend on requirement type.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: Minimal · up to 9efec

Cached top-level versions are now kept for dependency discovery, so their build edges are preserved and a later cache miss rebuilds in dependency order. The regression tests cover this behavior and the existing transitive filtering. No concrete merge-blocking risk was found; CI should still confirm the affected wheel builds.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: cached top-level versions now get dependency discovery in multiple-version bootstrap. It matches the raw summary and the PR objectives. It is short, single-sentence, a…
Description check Passed The description explains the problem (cached top-level versions lacked build edges and were omitted from build-order.json), the fix (retain cached top-level versions for dependency discovery), the tes…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: cached top-level versions now get dependency discovery in multiple-version bootstrap. It matches the raw summary and the PR objectives. It is short, single-sentence, and uses the conventional fix(bootstrap) prefix.

Full details: Description check

Explanation

The description explains the problem (cached top-level versions lacked build edges and were omitted from build-order.json), the fix (retain cached top-level versions for dependency discovery), the tests, and validation. It is directly related to the changeset.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 20d29aa and 9efec0e.

Files selected for processing: 2

  • src/fromager/bootstrapper/_resolve.py
  • tests/test_bootstrapper_iterative.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@mergify mergify Bot added the ci label Nov 16, 2026
@mergify

mergify Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue). If it does not match the queue conditions yet, it enters the queue once it does.

  • Queue this pull request

This branch was successfully deployed

1 active deployment
release — 9efec0e5 Deployed Nov 16, 2026 by vshawrh via Build and publish Python distributions to PyPI #1198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant