Skip to content

gh-90071: Stop freeing data which was never allocated - #100599

Open
DarthGandalf wants to merge 2 commits into
python:mainfrom
DarthGandalf:fixreadline
Open

gh-90071: Stop freeing data which was never allocated#100599
DarthGandalf wants to merge 2 commits into
python:mainfrom
DarthGandalf:fixreadline

Conversation

@DarthGandalf

@DarthGandalf DarthGandalf commented Dec 29, 2022

Copy link
Copy Markdown

@bedevere-bot

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost

ghost commented Dec 29, 2022

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@DarthGandalf DarthGandalf changed the title gh-90071: Stop freeing data which was never alloated gh-90071: Stop freeing data which was never allocated Dec 29, 2022
@carljm

carljm commented Jan 4, 2023

Copy link
Copy Markdown
Member

As I just commented on the issue, I don't see any evidence this is a bug in Python. Python is using the readline API correctly, and correctly ensuring that any history entry it frees is fully freed. If some other software is causing a history entry to have a garbage data pointer, the bug is in that package, not in Python.

@carljm carljm closed this Jan 4, 2023
@carljm

carljm commented Jan 5, 2023

Copy link
Copy Markdown
Member

Reopening based on discussion in issue. Still not sure it's really accurate to call this a bug in Python, but it does seem like the change is harmless and would avoid crashing in some edge cases when a broken version of readline is loaded by an extension module.

@carljm carljm reopened this Jan 5, 2023
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 12, 2026
@DarthGandalf

Copy link
Copy Markdown
Author

Well, ping? :)

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants