Repository navigation
Commit 1119ebb
authored
Drop the unused LLVM download from setup-qnn-deps.sh (#24098)
## Problem
`.ci/scripts/setup-qnn-deps.sh` calls `setup_libcpp`, which downloads a
575 MB LLVM release from GitHub. A connection reset in the middle of
that download fails the job:
```
curl: (56) OpenSSL SSL_read: Connection reset by peer, errno 104
Error: Failed to download LLVM
```
But nothing uses what `setup_libcpp` installs:
- Every workflow runs `setup-qnn-deps.sh` with `bash`, not `source`. So
the `LD_LIBRARY_PATH`, `LIBRARY_PATH` and `CPLUS_INCLUDE_PATH` values it
exports are gone when the script exits, and nothing else reads its
install folder.
- Its copy step does not pick up libc++ at all. The libc++ libraries are
in a subfolder its `lib/*.so*` glob does not reach.
- The QNN backend test jobs never call it, and they pass. The CI image
gets libc++ from the system package.
## Fix
Remove the `setup_libcpp 12` call and the `setup_libcpp` function, which
nothing else uses. This fixes the flaky download and saves about half a
minute of download and extraction per QNN job.
The Python setup path (`_stage_libcxx` in `download_qnn_sdk.py`)
downloads the same archive for users who have not set `QNN_SDK_ROOT`. It
is separate and not changed here.
## Testing
Shell syntax check on both scripts. The QNN CI jobs on this pull request
are the real test, since they run `setup-qnn-deps.sh` without the
download.
cc @cbilgin @psiddh1 parent ea34866 commit 1119ebb
2 files changed
Lines changed: 0 additions & 66 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
0 commit comments