Repository navigation
Commit 6e13047
[executorch][muse] Fix the DFlash final-block draft counts test
CudaDFlashNative.FinalWholeBlockFitsExactlyAndPreservesAllPrefillRows has
failed in unittest-cuda-muse-glimmer-batching since #24043 added draft
forward count checks to it:
Expected: (drained.draft_forwards - drain.draft_forwards) >
(drained.static_draft_forwards - drain.static_draft_forwards),
actual: 1 vs 1
The test expected the decode at position 78 to drain the 79 hidden rows
dynamically before the static draft. But run_target drains every owner
it touches right after appending hidden rows (#24042), so the 78-row
prefill already drains down to the fresh context (32). The decode then
holds at most one block of rows and takes a single static draft, and the
dynamic forwards fall before the window the test measured.
Measure from before the prefill instead: the prefill drains through
dynamic drafts only, and the decode runs exactly one static draft.1 parent 491e1ca commit 6e13047
1 file changed
Lines changed: 10 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
598 | 598 | | |
599 | 599 | | |
600 | 600 | | |
| 601 | + | |
601 | 602 | | |
602 | 603 | | |
603 | 604 | | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
604 | 610 | | |
605 | | - | |
606 | 611 | | |
607 | 612 | | |
608 | 613 | | |
609 | | - | |
610 | | - | |
611 | | - | |
612 | | - | |
613 | | - | |
614 | | - | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
615 | 618 | | |
616 | 619 | | |
617 | 620 | | |
| |||
0 commit comments