Skip to content

Commit d1f2e41

Browse files
Introduced correct calls and lintrunner
1 parent 48364c4 commit d1f2e41

22 files changed

Lines changed: 23 additions & 22 deletions

File tree

‎CMakeLists.txt‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -712,7 +712,8 @@ add_library(prim_ops_lib ${_prim_ops_lib__srcs})
712712
set_target_properties(prim_ops_lib PROPERTIES OUTPUT_NAME "executorch")
713713

714714
# DEPRECATED: executorch alias is kept purely for backwards compatibility.
715-
# External consumers linking to `executorch` will transparently link `prim_ops_lib`.
715+
# External consumers linking to `executorch` will transparently link
716+
# `prim_ops_lib`.
716717
add_library(executorch INTERFACE)
717718
target_link_libraries(executorch INTERFACE prim_ops_lib)
718719
target_link_libraries(prim_ops_lib PRIVATE executorch_core)

‎backends/cadence/CMakeLists.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ if(EXECUTORCH_CADENCE_CPU_RUNNER)
3636
# Find prebuilt libraries. executorch package should contain portable_ops_lib,
3737
# etdump, bundled_program.
3838
find_package(executorch CONFIG REQUIRED)
39-
executorch_target_link_options_shared_lib(executorch)
39+
executorch_target_link_options_shared_lib(prim_ops_lib)
4040
executorch_target_link_options_shared_lib(portable_ops_lib)
4141

4242
target_include_directories(

‎backends/mlx/examples/llm/CMakeLists.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ set(_flatbuffers_include ${EXECUTORCH_ROOT}/third-party/flatbuffers/include)
2828

2929
list(APPEND CMAKE_FIND_ROOT_PATH ${CMAKE_CURRENT_BINARY_DIR}/../../../..)
3030
find_package(executorch CONFIG REQUIRED FIND_ROOT_PATH_BOTH)
31-
executorch_target_link_options_shared_lib(executorch)
31+
executorch_target_link_options_shared_lib(prim_ops_lib)
3232

3333
# As in examples/models/llama: point gflags_DIR at the copy the executorch build
3434
# configured, since a separate find_package() project cannot see it.

‎examples/devtools/CMakeLists.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ set(_common_include_directories ${EXECUTORCH_ROOT}/..)
3939
# Find prebuilt libraries. executorch package should contain portable_ops_lib,
4040
# etdump, bundled_program.
4141
find_package(executorch CONFIG REQUIRED)
42-
executorch_target_link_options_shared_lib(executorch)
42+
executorch_target_link_options_shared_lib(prim_ops_lib)
4343
executorch_target_link_options_shared_lib(portable_ops_lib)
4444

4545
target_include_directories(executorch INTERFACE ${_common_include_directories})

‎examples/llm_server/cpp/CMakeLists.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ set(_json_include
2727
list(APPEND CMAKE_FIND_ROOT_PATH ${CMAKE_CURRENT_BINARY_DIR}/../../..)
2828
find_package(executorch CONFIG REQUIRED FIND_ROOT_PATH_BOTH)
2929
find_package(Threads REQUIRED)
30-
executorch_target_link_options_shared_lib(executorch)
30+
executorch_target_link_options_shared_lib(prim_ops_lib)
3131

3232
# Older installed packages may omit this header-only interface target.
3333
if(NOT TARGET extension_llm_session)

‎examples/models/dinov2/CMakeLists.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ list(APPEND CMAKE_FIND_ROOT_PATH ${CMAKE_CURRENT_BINARY_DIR}/../../..)
2828
find_package(executorch CONFIG REQUIRED FIND_ROOT_PATH_BOTH)
2929
get_target_property(_executorch_imported executorch IMPORTED)
3030
if(NOT _executorch_imported)
31-
executorch_target_link_options_shared_lib(executorch)
31+
executorch_target_link_options_shared_lib(prim_ops_lib)
3232
endif()
3333

3434
set(link_libraries executorch gflags)

‎examples/models/gemma3/CMakeLists.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ find_package(gflags REQUIRED)
3434
# Find `executorch` libraries, same as for gflags
3535
list(APPEND CMAKE_FIND_ROOT_PATH ${CMAKE_CURRENT_BINARY_DIR}/../../..)
3636
find_package(executorch CONFIG REQUIRED FIND_ROOT_PATH_BOTH)
37-
executorch_target_link_options_shared_lib(executorch)
37+
executorch_target_link_options_shared_lib(prim_ops_lib)
3838

3939
set(link_libraries executorch gflags)
4040
set(_srcs e2e_runner.cpp)

‎examples/models/gemma4/CMakeLists.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ find_package(gflags REQUIRED)
2828
# Find `executorch` libraries, same as for gflags
2929
list(APPEND CMAKE_FIND_ROOT_PATH ${CMAKE_CURRENT_BINARY_DIR}/../../..)
3030
find_package(executorch CONFIG REQUIRED FIND_ROOT_PATH_BOTH)
31-
executorch_target_link_options_shared_lib(executorch)
31+
executorch_target_link_options_shared_lib(prim_ops_lib)
3232

3333
set(link_libraries executorch gflags)
3434
set(_srcs e2e_runner.cpp)

‎examples/models/gemma4_31b/CMakeLists.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ find_package(Threads REQUIRED)
2727
# executorch
2828
list(APPEND CMAKE_FIND_ROOT_PATH ${CMAKE_CURRENT_BINARY_DIR}/../../..)
2929
find_package(executorch CONFIG REQUIRED FIND_ROOT_PATH_BOTH)
30-
executorch_target_link_options_shared_lib(executorch)
30+
executorch_target_link_options_shared_lib(prim_ops_lib)
3131

3232
set(link_libraries executorch gflags)
3333

‎examples/models/llava/CMakeLists.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ find_package(gflags REQUIRED)
8181
# find `executorch` libraries Same as for gflags
8282
list(APPEND CMAKE_FIND_ROOT_PATH ${CMAKE_CURRENT_BINARY_DIR}/../../..)
8383
find_package(executorch CONFIG REQUIRED FIND_ROOT_PATH_BOTH)
84-
executorch_target_link_options_shared_lib(executorch)
84+
executorch_target_link_options_shared_lib(prim_ops_lib)
8585

8686
set(LINK_LIBS executorch gflags extension_llm_runner)
8787
set(link_libraries ${LINK_LIBS})

0 commit comments

Comments
 (0)