Repository navigation
Commit fd9c7d2
authored
Skip the Muse Glimmer workload compile test on Windows (#24017)
### Problem
All four Windows unit test jobs (`unittest`, `unittest-editable` and
`unittest-release`, in `pull` and `trunk`) fail on `main` because of one
test:
```
FAILED .ci/scripts/tests/test_muse_glimmer_batching_workload.py::MuseGlimmerBatchingWorkloadTest::test_workload_without_a_model
AssertionError: unexpectedly None : CI workload tests require a C++ compiler
=== 1 failed, 1998 passed, 82 skipped, 14 deselected ===
```
The test builds a small C++ program by running the `c++` command with
GCC and Clang flags (`-std=c++17 -pthread -Werror ...`). Windows runners
have no `c++` command, so the test fails at its first check. The test
was added recently, and the Windows jobs were green on the commit before
it.
### Fix
Skip this one test on Windows. Other tests in `.ci/scripts/tests`
already do this when they need Unix-only tools, for example
`test_pybind_cmake.py`.
On Linux and macOS nothing changes. The test still requires the compiler
and still fails when it is missing. The CUDA job that this test was
written for runs on Linux, so it keeps full coverage there.
### Testing
- On macOS the test still builds and runs the C++ program and passes.
- With `sys.platform` set to `win32` the test is skipped.
- On macOS with no `c++` on `PATH` the test still fails with the same
assertion, so the check is not weakened.1 parent a39d597 commit fd9c7d2
1 file changed
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
19 | 23 | | |
20 | 24 | | |
21 | 25 | | |
| |||
0 commit comments