Skip to content

Update constructor args supplying too few parameters - #14802

Closed
benjaminglass1 wants to merge 1 commit into
pytorch:mainfrom
benjaminglass1:standardize_tuple_len
Closed

benjaminglass1 wants to merge 1 commit into
pytorch:mainfrom
benjaminglass1:standardize_tuple_len

Conversation

@benjaminglass1

Copy link
Copy Markdown

This is a prerequisite for pytorch/pytorch#162340. The CI pin will be reverted before merge.

@pytorch-bot

pytorch-bot Bot commented Oct 4, 2025 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14802

Note: Links to docs will display an error until the docs builds have been completed.

❌ 38 New Failures, 8 Cancelled Jobs, 3 Unrelated Failures

As of commit cad4679 with merge base ab5fb84 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2025
@benjaminglass1
benjaminglass1 marked this pull request as draft October 4, 2025 01:42
@github-actions

github-actions Bot commented Oct 4, 2025

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@benjaminglass1

Copy link
Copy Markdown
Author

@pytorchbot label "topic: not user facing"

@benjaminglass1

Copy link
Copy Markdown
Author

@huydhn Could you approve the workflow run? I don't have access to CI on this repo like I do on the main pytorch repo.

This is a prerequisite for pytorch/pytorch#162340.
The CI pin will be reverted before merge.
@benjaminglass1
benjaminglass1 marked this pull request as ready for review October 8, 2025 11:05
@digantdesai

digantdesai commented Oct 9, 2025 •

Copy link
Copy Markdown
Contributor

Is this a backwards compatible change? I.e. why do we need to update the Pytorch pin for this, curious.

@github-actions

github-actions Bot commented Dec 9, 2025

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions Bot added the Stale PRs inactive for over 60 days label Dec 9, 2025
@github-actions

github-actions Bot commented Feb 7, 2026

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

1 similar comment
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Stale PRs inactive for over 60 days topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants