Skip to content

Update MG README with offgraph cache and batching - #23909

Draft
metascroy wants to merge 4 commits into
mainfrom
update-mg-readme-offgraph
Draft

metascroy wants to merge 4 commits into
mainfrom
update-mg-readme-offgraph

Conversation

@metascroy

@metascroy metascroy commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

This updates the MG README to reflect the offgraph cache and continuous batching support.

I'll hold off merging until the instructions are vetted for CUDA (cc @Gasoonjia)

@pytorch-bot

pytorch-bot Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23909

Note: Links to docs will display an error until the docs builds have been completed.

❌ You can merge normally! (1 Unrelated Failure), 1 Unclassified Failure

As of commit ddc40b7 with merge base 34b934b (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2026
@metascroy

Copy link
Copy Markdown
Contributor Author

cc @Gasoonjia look over content for CUDA as well

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Documentation update assisted by OpenAI Codex.
Comment thread examples/models/muse-glimmer/README.md Outdated
drafter configuration. Changing N does not change D: a D = 16 export still
evaluates 16 drafter rows per session when N = 3, and its default is N = 15.

Sampling behavior depends on the backend. On MLX, draft proposals are always

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop this. It doesn't matter what sampling params apply to the draft (it's an implementation detail).

Rejection sampling guarantees that the overall draft-target process has the sampling params requested by the user.

Documentation update assisted by OpenAI Codex.

This branch was successfully deployed

1 active deployment
cadence — ddc40b7d Deployed Oct 16, 2026 by Gasoonjia via hifi-op-test / hifi4 #33908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants