Skip to content

[executorch][muse] Verify CUDA DFlash drafts on device under any sampling - #23984

Open
Gasoonjia wants to merge 3 commits into
gh/Gasoonjia/83/basefrom
gh/Gasoonjia/83/head
Open

Gasoonjia wants to merge 3 commits into
gh/Gasoonjia/83/basefrom
gh/Gasoonjia/83/head

Conversation

@Gasoonjia

@Gasoonjia Gasoonjia commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Export dflash_verify / dflash_verify_argmax: batched on-device acceptance of
every owner's drafts under that owner's temperature / top-k / top-p, with a
greedy fast path. Only token IDs return to the host. Uniforms come from
(seed, position, purpose) so results do not depend on batch composition.
Target preamble sampling also stays on device (CudaExecutor::sample_rows).

Differential Revision: D125705716

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23984

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Cancelled Jobs, 1 Unclassified Failure

As of commit c4da950 with merge base 897d28f (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[ghstack-poisoned]
[ghstack-poisoned]
@Gasoonjia
Gasoonjia deployed to upload-benchmark-results October 19, 2026 09:33 — with GitHub Actions Active

This branch was successfully deployed

2 active deployments
upload-benchmark-results — c4da9500 Deployed Oct 19, 2026 by Gasoonjia via upload-benchmark-results #21060
cadence — c4da9500 Deployed Oct 19, 2026 by Gasoonjia via hifi-op-test / hifi4 #34057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants