Skip to content

Skip the batch sampler runtime test on ROCm #24013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Oct 20, 2026
Merged

Skip the batch sampler runtime test on ROCm #24013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion backends/cuda/tests/test_batch_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
from executorch.exir.passes import MemoryPlanningPass
from executorch.exir.passes.propagate_device_pass import PropagateDeviceConfig
from executorch.extension.llm.batching.sampler import BatchSampler
from executorch.runtime import Runtime


def export_sampler(directory: Path, vocab: int):
Expand Down Expand Up @@ -56,8 +55,14 @@ def export_sampler(directory: Path, vocab: int):


@unittest.skipUnless(torch.cuda.is_available(), "CUDA required")
@unittest.skipIf(
torch.version.hip is not None,
"loads through the Python runtime, which the ROCm build does not include",
)
class CudaBatchSamplerTest(unittest.TestCase):
def test_dynamic_rows_with_masked_reduction_lanes(self):
from executorch.runtime import Runtime

# A vocabulary spanning several reduction tiles exposes padding lanes.
vocab = 202048
with tempfile.TemporaryDirectory() as temporary:
Expand Down
Loading