Skip to content

Give test-qnn-python-imports-linux 30 minutes instead of 15 - #24092

Merged
shoumikhin merged 1 commit into
pytorch:mainfrom
shoumikhin:qnn-imports-timeout
Oct 23, 2026
Merged

shoumikhin merged 1 commit into
pytorch:mainfrom
shoumikhin:qnn-imports-timeout

Conversation

@shoumikhin

@shoumikhin shoumikhin commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Problem

test-qnn-python-imports-linux has a 15 minute timeout, the shortest in pull.yml. That limit becomes the job's timeout-minutes, so it also covers pulling the large QNN image, checking out submodules and the cache setup steps, not only the test script.

Those setup steps vary from run to run. Over the last day, successful runs took 9 to 15 minutes, often over 13. Runs that went past 15 were killed. 5 of the last 14 runs on main ended this way, with the script itself taking its usual 7 to 8 minutes. When the job hits the limit, GitHub cancels it, and the pull run on that commit ends as cancelled instead of green.

Fix

Raise the limit to 30 minutes, the smallest value already used in this workflow. A slow runner then no longer fails the job, and a real hang is still caught.

Testing

No local test, since this only changes a CI limit. The timings above come from the job and step durations of recent runs.

The job's `timeout` becomes the job-level timeout-minutes, so it covers
pulling the QNN image, checking out submodules and the cache setup steps,
not just the script. Over the last day the successful runs took 9 to 15
minutes (often over 13), and 5 of the last 14 runs on main went past 15
and were killed. GitHub reports a timed-out job as "cancelled", which counts as a
failure for the pull workflow.

Raise the limit to 30 minutes, the smallest value already used in this
workflow, so an ordinary slow runner no longer fails the job.

Test plan: none locally; this only changes a CI limit. Timings come from
the job and step durations of recent runs in the Actions API.
@shoumikhin shoumikhin added the release notes: none Do not include this in the release notes label Oct 22, 2026
@pytorch-bot

pytorch-bot Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24092

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c8e0968 with merge base 6368414 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copilot AI balanced review requested due to automatic review settings October 22, 2026 20:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 22, 2026
@shoumikhin
shoumikhin merged commit ea34866 into pytorch:main Oct 23, 2026
342 of 354 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants