Repository navigation
[executorch][cuda] Find the tuned INT4 kernel's def under its module-level name too - #24096
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24096
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 Unclassified FailuresAs of commit a655c56 with merge base 1dbb8e7 ( UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Gasoonjia
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
7997fd3
into
gh/bobrenjc93/1/base
Stack from ghstack (oldest at bottom):
test_a_tuned_shape_traces_only_its_picked_configfinds the user kernel in Inductor's wrapper by the exact textdef _int4_w4a16_direct_kernel(. That only matches the wrapper'sasync_compile.triton('''...''')string form, which keeps the kernel's own name.pytorch/pytorch#200502 makes Inductor's python wrapper define each Triton kernel as module-level code by default. There, the def takes Inductor's kernel name,
_int4_w4a16_direct_kernel_0. The test failed on its DiffTrain import, D126740082, which was reverted partly for this.The test now matches
^def <name>\w*\(and slices back to theuser_autotune(before that match. The decorator'sconfigs=[...]still comes right before the def in both forms, so the check that only the picked config is traced is unchanged. This lands ahead of the #200502 reland.@landed-with-radar-review
Differential Revision: D126992211