Skip to content

[executorch][cuda] Find the tuned INT4 kernel's def under its module-level name too - #24096

Merged
meta-codesync[bot] merged 1 commit into
gh/bobrenjc93/1/basefrom
gh/bobrenjc93/1/head
Oct 22, 2026
Merged

meta-codesync[bot] merged 1 commit into
gh/bobrenjc93/1/basefrom
gh/bobrenjc93/1/head

Conversation

@bobrenjc93

@bobrenjc93 bobrenjc93 commented Oct 22, 2026 •

Copy link
Copy Markdown

Stack from ghstack (oldest at bottom):

test_a_tuned_shape_traces_only_its_picked_config finds the user kernel in Inductor's wrapper by the exact text def _int4_w4a16_direct_kernel(. That only matches the wrapper's async_compile.triton('''...''') string form, which keeps the kernel's own name.

pytorch/pytorch#200502 makes Inductor's python wrapper define each Triton kernel as module-level code by default. There, the def takes Inductor's kernel name, _int4_w4a16_direct_kernel_0. The test failed on its DiffTrain import, D126740082, which was reverted partly for this.

The test now matches ^def <name>\w*\( and slices back to the user_autotune( before that match. The decorator's configs=[...] still comes right before the def in both forms, so the check that only the picked config is traced is unchanged. This lands ahead of the #200502 reland.


@landed-with-radar-review

Differential Revision: D126992211

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24096

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 Unclassified Failures

As of commit a655c56 with merge base 1dbb8e7 (image):

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 22, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Gasoonjia Gasoonjia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync
meta-codesync Bot merged commit 7997fd3 into gh/bobrenjc93/1/base Oct 22, 2026
289 of 309 checks passed
@meta-codesync
meta-codesync Bot deleted the gh/bobrenjc93/1/head branch October 22, 2026 23:23
@meta-codesync
meta-codesync Bot deployed to cherry-pick-bot October 22, 2026 23:23 Active
@bobrenjc93
bobrenjc93 deployed to upload-benchmark-results October 23, 2026 01:33 — with GitHub Actions Active

This branch was successfully deployed

2 active and 1 inactive deployments
upload-benchmark-results — a655c56a Deployed Oct 23, 2026 by bobrenjc93 via upload-benchmark-results #21213
cherry-pick-bot — a655c56a Deployed Oct 22, 2026 by meta-codesync[bot] via Try to create a PR with ghstack /orig branch #1864
cadence — a655c56a Deployed Oct 22, 2026 by bobrenjc93 via hifi-op-test / hifi4 #34401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants