Repository navigation
Find the tuned INT4 kernel's def under its module-level name too - #24097
bobrenjc93 wants to merge 1 commit into
Conversation
Summary:
`test_a_tuned_shape_traces_only_its_picked_config` finds the user kernel in Inductor's wrapper by the exact text `def _int4_w4a16_direct_kernel(`. That only matches the wrapper's `async_compile.triton('''...''')` string form, which keeps the kernel's own name.
pytorch/pytorch#200502 makes Inductor's python wrapper define each Triton kernel as module-level code by default. There, the def takes Inductor's kernel name, `_int4_w4a16_direct_kernel_0`. The test failed on its DiffTrain import, D126740082, which was reverted partly for this.
The test now matches `^def <name>\w*\(` and slices back to the `user_autotune(` before that match. The decorator's `configs=[...]` still comes right before the def in both forms, so the check that only the picked config is traced is unchanged. This lands ahead of the #200502 reland.
___
landed-with-radar-review
Differential Revision: D126992211
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24097
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 Pending, 3 Unrelated Failures, 2 Unclassified FailuresAs of commit c3a199b with merge base 6368414 ( UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Summary:
test_a_tuned_shape_traces_only_its_picked_configfinds the user kernel in Inductor's wrapper by the exact textdef _int4_w4a16_direct_kernel(. That only matches the wrapper'sasync_compile.triton('''...''')string form, which keeps the kernel's own name.pytorch/pytorch#200502 makes Inductor's python wrapper define each Triton kernel as module-level code by default. There, the def takes Inductor's kernel name,
_int4_w4a16_direct_kernel_0. The test failed on its DiffTrain import, D126740082, which was reverted partly for this.The test now matches
^def <name>\w*\(and slices back to theuser_autotune(before that match. The decorator'sconfigs=[...]still comes right before the def in both forms, so the check that only the picked config is traced is unchanged. This lands ahead of the #200502 reland.landed-with-radar-review
Differential Revision: D126992211