Repository navigation
Drop the unused LLVM download from setup-qnn-deps.sh - #24098
Merged
Merged
Conversation
shoumikhin
added
the
release notes: none
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24098
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 9 PendingAs of commit d931ab8 with merge base 2c3e231 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Gasoonjia
approved these changes
Oct 23, 2026
psiddh
added
the
module: qnn
psiddh
approved these changes
Oct 23, 2026
setup-qnn-deps.sh calls setup_libcpp, which downloads a 575 MB LLVM release from GitHub. A connection reset during that download fails QNN CI jobs, but nothing uses what it installs: - Every workflow runs setup-qnn-deps.sh with bash, so the paths setup_libcpp exports are gone when the script exits, and nothing else reads its install folder. - Its copy step does not even pick up libc++. The libc++ libraries sit in a subfolder its glob does not reach. - The QNN backend test jobs never call it and pass. The CI image gets libc++ from the system package. Remove the call and the function, which nothing else uses. This fixes the flaky download and saves about half a minute per QNN job.
shoumikhin
force-pushed
the
qnn-llvm-download-retry
branch
from
October 23, 2026 06:16
38f11e7 to
d931ab8
Compare
shoumikhin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.ci/scripts/setup-qnn-deps.shcallssetup_libcpp, which downloads a 575 MB LLVM release from GitHub. A connection reset in the middle of that download fails the job:But nothing uses what
setup_libcppinstalls:setup-qnn-deps.shwithbash, notsource. So theLD_LIBRARY_PATH,LIBRARY_PATHandCPLUS_INCLUDE_PATHvalues it exports are gone when the script exits, and nothing else reads its install folder.lib/*.so*glob does not reach.Fix
Remove the
setup_libcpp 12call and thesetup_libcppfunction, which nothing else uses. This fixes the flaky download and saves about half a minute of download and extraction per QNN job.The Python setup path (
_stage_libcxxindownload_qnn_sdk.py) downloads the same archive for users who have not setQNN_SDK_ROOT. It is separate and not changed here.Testing
Shell syntax check on both scripts. The QNN CI jobs on this pull request are the real test, since they run
setup-qnn-deps.shwithout the download.cc @cbilgin @psiddh