Repository navigation
[executorch][cuda] Find the tuned INT4 kernel's def under its module-level name too - #24103
Closed
pytorchbot wants to merge 1 commit into
Closed
pytorchbot wants to merge 1 commit into
pytorchbot wants to merge 1 commit into
Conversation
…level name too
`test_a_tuned_shape_traces_only_its_picked_config` finds the user kernel in Inductor's wrapper by the exact text `def _int4_w4a16_direct_kernel(`. That only matches the wrapper's `async_compile.triton('''...''')` string form, which keeps the kernel's own name.
pytorch/pytorch#200502 makes Inductor's python wrapper define each Triton kernel as module-level code by default. There, the def takes Inductor's kernel name, `_int4_w4a16_direct_kernel_0`. The test failed on its DiffTrain import, D126740082, which was reverted partly for this.
The test now matches `^def <name>\w*\(` and slices back to the `user_autotune(` before that match. The decorator's `configs=[...]` still comes right before the def in both forms, so the check that only the picked config is traced is unchanged. This lands ahead of the #200502 reland.
___
landed-with-radar-review
Differential Revision: [D126992211](https://our.internmc.facebook.com/intern/diff/D126992211/)
ghstack-source-id: 454871348
Pull-Request: #24096
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24103
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #24096 by @bobrenjc93
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/bobrenjc93/1/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/bobrenjc93/1/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/bobrenjc93/1/orig
Differential Revision: D126992211
@diff-train-skip-merge