Skip to content

Commit b82e878

Browse files
authored
[Quality] Exercise tensor lambda test cases (#4170)
1 parent 7f04979 commit b82e878

1 file changed

Lines changed: 11 additions & 4 deletions

File tree

‎test/objectives/test_values.py‎

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1580,7 +1580,8 @@ def test_gae(self, device, gamma, lmbda, N, T, dtype, has_done):
15801580
"gamma_tensor", ["scalar", "tensor", "tensor_single_element"]
15811581
)
15821582
@pytest.mark.parametrize(
1583-
"lmbda_tensor", ["scalar", "tensor", "tensor_single_element"]
1583+
"lmbda_tensor",
1584+
["scalar", "tensor", "tensor_zero_dim", "tensor_single_element"],
15841585
)
15851586
def test_gae_param_as_tensor(
15861587
self, device, N, dtype, has_done, gamma_tensor, lmbda_tensor
@@ -1609,7 +1610,9 @@ def test_gae_param_as_tensor(
16091610

16101611
if lmbda_tensor == "tensor":
16111612
lmbda_vec = torch.full_like(reward, lmbda)
1612-
elif gamma_tensor == "tensor_single_element":
1613+
elif lmbda_tensor == "tensor_zero_dim":
1614+
lmbda_vec = torch.as_tensor(lmbda, device=device)
1615+
elif lmbda_tensor == "tensor_single_element":
16131616
lmbda_vec = torch.as_tensor([lmbda], device=device)
16141617
else:
16151618
lmbda_vec = lmbda
@@ -1934,7 +1937,9 @@ def test_tdlambda_tensor_gamma(self, device, gamma, lmbda, N, T, has_done):
19341937
@pytest.mark.parametrize(
19351938
"gamma_tensor", ["scalar", "tensor", "tensor_single_element"]
19361939
)
1937-
@pytest.mark.parametrize("lmbda_tensor", ["scalar", "tensor_single_element"])
1940+
@pytest.mark.parametrize(
1941+
"lmbda_tensor", ["scalar", "tensor_zero_dim", "tensor_single_element"]
1942+
)
19381943
def test_tdlambda_tensor_gamma_single_element(
19391944
self, device, gamma, lmbda, N, T, F, has_done, gamma_tensor, lmbda_tensor
19401945
):
@@ -1960,7 +1965,9 @@ def test_tdlambda_tensor_gamma_single_element(
19601965
else:
19611966
gamma_vec = gamma
19621967

1963-
if gamma_tensor == "tensor_single_element":
1968+
if lmbda_tensor == "tensor_zero_dim":
1969+
lmbda_vec = torch.as_tensor(lmbda, device=device)
1970+
elif lmbda_tensor == "tensor_single_element":
19641971
lmbda_vec = torch.as_tensor([lmbda], device=device)
19651972
else:
19661973
lmbda_vec = lmbda

0 commit comments

Comments
 (0)