Skip to content

Pipfile.Updater fails test when trying to delete temporary file before it is closed #54

Description

@ptmcg
  • Dependency Parser version:
  • Python version: 3.10
  • Operating System: Windows 10

Description

Test failure while trying to os.remove a file that had not yet been closed.

What I Did

While running tests with tox, got the following error:

        data = open(pipfile.name).read()
>       os.remove(pipfile.name)
E       PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\ptmcg\\AppData\\Local\\Temp\\tmpwetzvkjv'

FAILED tests/test_updater.py::test_update_pipfile - PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\ptmcg\\AppData\...

Fixed by changing the "data.open(pipfile.name).read()" line in dparse/updater.py to:

        with open(pipfile.name) as pf:
            data = pf.read()
        pipfile.close()

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions