qBraid Algos v0.1 - #56
Merged
Merged
Conversation
fixed coverage report test
…xample for Bell's
…lete / ready for review yet (needs testing)
…e bells inequality example circuit. load_program and load_subroutine available for these.
LukeAndreesen
marked this pull request as draft
August 4, 2025 21:23
LukeAndreesen
marked this pull request as ready for review
August 14, 2025 22:20
* format / structure updates * fix mypy + test deps * add missing qpe.qasm file
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
ryanhill1
requested changes
Aug 15, 2025
ryanhill1
left a comment
ryanhill1
left a comment
Member
There was a problem hiding this comment.
Can you write a couple tests for the CLI? Doesn't have to be full coverage, but just a couple to cover the main use case(s).
ryanhill1
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of Bernstein-Vazirani, Quantum Fourier Transform, Inverse Quantum Fourier Transform, Quantum Phase Estimation - version 0.1 qBraid Algos
Addresses: #54 (comment)
load_programmethod for each algorithm, which takes user-defined parameters and returns a PyQASM module for the algorithm with the appropriate parameters.generate_submodulemethod for each algorithm, which takes user-defined parameters and generates a .qasm file in the user's cwd with the algorithm as a subroutine, for use in custom circuitsgenerate_oraclewhich does the same as above, but for just a string-encoded oracle, rather than entire BernVaz circuit