passing context to execute method for initiating step JIT with data from context - #156
Open
infoneershalin wants to merge 6 commits into
Open
infoneershalin wants to merge 6 commits into
infoneershalin wants to merge 6 commits into
Conversation
added 6 commits
July 27, 2017 20:21
…e fileName is different.
Contributor
|
This solution will have issues as step didn't proxied for data driven test. It may resolve current issue but will introduce new issues. |
Author
|
I did not get which kind of issues will be introduced?
I have tested it on multiple scenarios as per my knowledge and have executed unit tests also.
Other option is whatever proxy steps were doing we can add that logic in execute method of Scenario class if contaxt is not null.
On 29-Nov-2017 9:35 PM, cjayswal <notifications@github.com> wrote:
This solution will have issues as step didn't proxied for data driven test. It may resolve current issue but will introduce new issues.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#156 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATpW8EEJUryvQLltOE69PxRFWkbSCBeFks5s7YCvgaJpZM4Quqz9>.
|
Contributor
|
Well, refer resolution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolution for issue #154